Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/lsp): Sort repl completions #15171

Merged
merged 2 commits into from
Jul 13, 2022
Merged

feat(cli/lsp): Sort repl completions #15171

merged 2 commits into from
Jul 13, 2022

Conversation

yoseio
Copy link
Contributor

@yoseio yoseio commented Jul 12, 2022

fixes #15160

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

dsherret
dsherret requested changes Jul 12, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I think we can just sort the items vector in place without adding a dependency.

cli/lsp/repl.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @2shiori17!

@dsherret dsherret merged commit 61340f1 into denoland:main Jul 13, 2022
@yoseio yoseio deleted the sort-completions branch July 13, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort registry completions in the repl
3 participants
@yoseio @CLAassistant @dsherret