fix: fallback to no type checking cache when db file can't be created #15180
Conversation
cli/cache/check.rs
Outdated
| match Self::try_new(db_file_path) { | ||
| Ok(cache) => cache, | ||
| Err(err) => { | ||
| log::debug!("Creating the type checking cache failed.\n{:#}", err); |
There was a problem hiding this comment.
suggestion: warn that type checking is disabled if it was specified as enabled somewhere? Clearly we are changing the behaviour and we shouldn't do that silently.
There was a problem hiding this comment.
Type checking isn't disabled in this case. When this fails it will always type check instead of potentially having a performance improvement and skipping type checking. So it's not really a behaviour change, but just a savings that someone won't have when it fails. Perhaps it would still be worthwhile to warn?
(I'm going to update this to try again to create the db when it fails to open)
There was a problem hiding this comment.
Well it does warn, right? The title just confused me in the sense I stopped reading the title I skipped the "cache" word. Any warning that tells them any action to take makes sense to me, but it is internal "performance" versus what I assumed what a change in behaviour.
There was a problem hiding this comment.
Currently it won't warn and will just show this message only when debug logging is enabled. I was thinking we could tell people to run with debug logging in case they find the type checking cache never works for them so we could get more details. I'm not sure if this will be a widespread problem.
Co-authored-by: Kitson Kelly <me@kitsonkelly.com>
Resolves a todo I forgot to resolve in #15118.