feat(test): add --parallel flag, soft deprecate --jobs
#15259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jul 20, 2022
| Defaults to number of available CPUs when used with | ||
| --jobs flag and no value is provided. | ||
| Defaults to 1 when --jobs flag is not used. | ||
| DENO_JOBS Number of parallel workers used for the --parallel |
There was a problem hiding this comment.
I thought about renaming this, but DENO_MAX_PARALLELISM is long. Additionally, cargo uses CARGO_JOBS for this env variable, so I think it makes sense? We can also reuse this env var for deno fmt and lint in the future. Thoughts?
bartlomieju
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soft deprecation of
--jobsflag. There are some problems with it as outlined in #14533 (comment)In summary:
--jobsis not easy to use on its own as a binary option because it doesn't require an equals sign after it. So if you do something likedeno test --jobs test_file.tsit will fail parsing "test_file.ts" to a number."parallel": trueto the config file in the future.Supersedes #15225
Closes #14533
Co-authored-by: @mrkldshv