Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/crypto): interoperable import/export #16153

Merged
merged 2 commits into from
Oct 4, 2022
Merged

fix(ext/crypto): interoperable import/export #16153

merged 2 commits into from
Oct 4, 2022

Conversation

panva
Copy link
Contributor

@panva panva commented Oct 4, 2022

This PR updates RSA key import/export to a state which is interoperable with other implementations.

For RSA the only OID in and out is rsaEncryption.
For EC the only OID in and out is id-ecpublickey (fixed in #16152).

see w3c/webcrypto#307 (comment)
see w3c/webcrypto#307
see w3c/webcrypto#305
see nodejs/node#42816

@panva
Copy link
Contributor Author

panva commented Oct 4, 2022

cc @littledivy

@littledivy littledivy merged commit 0d042d8 into denoland:main Oct 4, 2022
@ry
Copy link
Member

ry commented Oct 5, 2022

Thanks for the patch @panva

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants