feat(unstable): Add "Deno.osUptime()" API #17179
Conversation
|
Implementation wise - looks good. However when adding new APIs to Deno namespace, we also start with making them unstable (requiring
Seems it's not needed - |
cli/tsc/dts/lib.deno.ns.d.ts
Outdated
| * @tags allow-sys | ||
| * @category Runtime Environment | ||
| */ | ||
| export function uptime(): number; |
There was a problem hiding this comment.
Little bike-shedding maybe it should be Deno.osUptime()?
There was a problem hiding this comment.
Deno.osUptime() is more clear and falls in line with the naming convention of Deno.osRelease(). I definitely prefer it over Deno.uptime().
I would also like to bikeshed another alternative being Deno.systemUptime() (which is in line with Deno.systemMemoryInfo(). I don't have strong feelings either way.
There was a problem hiding this comment.
After checking few other places, I decided to go with osUptime, as:
the uptime is a kernel internal value, which ticks up every cycle, it starts counting when the kernel has initialized. That is, when the first cycle has ended. Even before anything is mounted, directly after the bootloader gives control to the kernel image.
which means that IMO it should be treated as Operating System info, where System info should be more "hardware-like" related, as in mem/cpu/peripherals etc.
|
LGTM, nice work! |
bartlomieju
changed the title
This PR adds support for `Deno.osUptime` which reports number of seconds since os was booted. It will allow us to be compatible with Node's `os.uptime` - https://nodejs.org/api/os.html#osuptime Partially based on https://docs.rs/uptime_lib/latest/src/uptime_lib/lib.rs.html
This PR adds support for
Deno.uptimewhich reports number of seconds since os was booted.It will allow us to be compatible with Node's
os.uptime- https://nodejs.org/api/os.html#osuptimeThere's also
process.uptime, but I believeDeno.uptimeshould report stats for the OS itself, not the process, and we can always addDeno.processUptimeor similar method when it'll become necessary.Partially based on https://docs.rs/uptime_lib/latest/src/uptime_lib/lib.rs.html