refactor(info): Remove emit and map keys from json output #17816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kamilogorek just a note that the issues tagged with "suggestion" are ones that aren't necessary agreed upon (so they can be risky to just do and I wouldn't recommend doing them in the future because of that). I added it to the 2.0 milestone so that it would be discussed. That said, this most likely will be done I think, but it would be a deno_graph fix rather than just doing .remove(...) from the json output, but I wouldn't recommend working on it because I'm doing a big deno_graph refactor at the moment. |
|
Sure thing, I've noticed that, but no worries. It's usually just a good way to familiarize myself with different parts of the repo. If it gets closed, it gets closed :) |
aapoalas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17703