refactor: remove global_eval.ts #1813
Conversation
| // TODO: this should be replaced with globalThis | ||
| // when the proposal goes to stage 4 | ||
| // See https://github.com/tc39/proposal-global | ||
| export const window = (0, eval)("this"); |
There was a problem hiding this comment.
it is indirect eval
https://tc39.github.io/ecma262/#sec-performeval
There was a problem hiding this comment.
Yes, it's indirect call of eval. Basically the same as the previous code. Please see the stackoverflow link above for details.
There was a problem hiding this comment.
Please add a comment.. Something like this
// (0, eval) is indirect eval https://tc39.github.io/ecma262/#sec-performeval
kt3k
force-pushed
the
feature/global-eval
branch
from
aed71ea to
efd9fe6
Compare
|
Updated the comments. Fixed the lint errors. |
| // - https://stackoverflow.com/a/14120023 | ||
| // - https://tc39.github.io/ecma262/#sec-performeval (spec) | ||
| export const window = (0, eval)("this"); | ||
| // TODO: The above should be replaced with globalThis |
There was a problem hiding this comment.
globalThis is already in the runtime... We should be able to do this now, but when I tried it before, there was some sort of error in the snapshotting, I don't know if the snapshot is being done with the right config or some other issue.
|
@kitsonk |
|
@kt3k from the notes: https://tc39.github.io/tc39-notes/2019-01_jan-31.html#globalthis-follow-up it was decided to keep TypeScript is just about to implement it into master: microsoft/TypeScript#29332 |
|
@kitsonk Thank you for the pointer! OK. Let's replace it soon! 👍 |
This PR replaced the
globalEvalusages with exportedwindowobject. I created//js/window.tsfile to separateconst windowdeclaration from other globals settings and avoid circular reference.