Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ext/node): port pbkdf2 to Rust #18470

Merged
merged 6 commits into from
Mar 28, 2023
Merged

chore(ext/node): port pbkdf2 to Rust #18470

merged 6 commits into from
Mar 28, 2023

Conversation

littledivy
Copy link
Member

Towards #18455

@littledivy littledivy marked this pull request as draft March 28, 2023 05:45
@littledivy littledivy mentioned this pull request Mar 28, 2023
Closed
39 tasks
@littledivy littledivy marked this pull request as ready for review March 28, 2023 08:37
bartlomieju
bartlomieju approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one nitpick

cli/tests/unit_node/internal/pbkdf2_test.ts Outdated Show resolved Hide resolved
@littledivy littledivy enabled auto-merge (squash) March 28, 2023 09:05
@littledivy littledivy merged commit 67e21e7 into denoland:main Mar 28, 2023
mmastrac pushed a commit that referenced this pull request Mar 31, 2023
@littledivy @mmastrac
chore(ext/node): port pbkdf2 to Rust (#18470)
2d3be63 
Towards #18455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @bartlomieju