fix(ext/node): implement crypto.Sign (RSA/PEM/SHA{224,256,384,512}) #18471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Mar 28, 2023
There was a problem hiding this comment.
LGTM, but I will let @littledivy take another look before merging
littledivy
approved these changes
Mar 28, 2023
Cargo.toml
Outdated
| @@ -136,7 +137,7 @@ uuid = { version = "1.3.0", features = ["v4"] } | |||
| zstd = "=0.11.2" | |||
|
|
|||
| # crypto | |||
| rsa = { version = "0.7.0", default-features = false, features = ["std", "pem"] } | |||
| rsa = { version = "0.7.0", default-features = false, features = ["std", "pem", "hazmat"] } | |||
There was a problem hiding this comment.
Can you add a comment here why hazmat feature is used? "hazmat needed for PrehashSigner in ext/node"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
crypto.Sign(createSign) API for node compat layer with support of RSAkey in pem format with digest algorithms
SHA224,SHA256,SHA384, andSHA512.part of #18455