Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): add X509Certificate #18625

Merged
merged 2 commits into from
Apr 7, 2023
Merged

fix(ext/node): add X509Certificate #18625

merged 2 commits into from
Apr 7, 2023

Conversation

littledivy
Copy link
Member

Towards #18455

@littledivy littledivy mentioned this pull request Apr 7, 2023
Closed
39 tasks
@littledivy littledivy marked this pull request as ready for review April 7, 2023 08:20
@littledivy littledivy requested a review from bartlomieju April 7, 2023 08:55
bartlomieju
bartlomieju reviewed Apr 7, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of dependencies 😬 are there any other Node.js test files that we could enable maybe?

@littledivy
Copy link
Member Author

@bartlomieju this seems to be the only test for standalone usage of X509Certificate

bartlomieju
bartlomieju approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit a0dd0cb into denoland:main Apr 7, 2023
levex pushed a commit that referenced this pull request Apr 12, 2023
@littledivy @levex
fix(ext/node): add X509Certificate (#18625)
f731dbd 
Towards #18455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@littledivy @bartlomieju