fix(ext/node): implement asymmetric keygen #18651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
littledivy
changed the title
littledivy
commented
Apr 15, 2023
Comment on lines
-3298
to
+3331
| "der", | ||
| "pkcs8", | ||
| "spki", | ||
| "der 0.6.1", | ||
| "pkcs8 0.9.0", | ||
| "spki 0.6.0", |
There was a problem hiding this comment.
we need to upgrade all the RustCrypto deps. I'll do it after this lands.
bartlomieju
reviewed
Apr 16, 2023
bartlomieju
reviewed
Apr 18, 2023
bartlomieju
approved these changes
Apr 19, 2023
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Apr 20, 2023
Towards denoland#18455 This commit implements the keypair generation for asymmetric keys for the `generateKeyPair` API. See how key material is managed in this implementation: https://www.notion.so/denolandinc/node-crypto-design-99fc33f568d24e47a5e4b36002c5325d?pvs=4 Private and public key encoding depend on `KeyObject#export` which is not implemented. I've also skipped ED448 and X448 since we need a crate for that in WebCrypto too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #18455
This commit implements the keypair generation for asymmetric keys for the
generateKeyPairAPI.See how key material is managed in this implementation: https://www.notion.so/denolandinc/node-crypto-design-99fc33f568d24e47a5e4b36002c5325d?pvs=4
Private and public key encoding depend on
KeyObject#exportwhich is not implemented. I've also skipped ED448 and X448 since we need a crate for that in WebCrypto too.