Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): implement crypto.createVerify #18703

Merged
merged 3 commits into from
Apr 18, 2023
Merged

fix(ext/node): implement crypto.createVerify #18703

merged 3 commits into from
Apr 18, 2023

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Apr 14, 2023

part of #18455

This PR implements crypto.createVerify API.

@kt3k kt3k marked this pull request as ready for review April 15, 2023 06:28
@kt3k kt3k requested review from bartlomieju and littledivy April 15, 2023 09:41
@kt3k kt3k mentioned this pull request Apr 15, 2023
Closed
39 tasks
bartlomieju
bartlomieju reviewed Apr 16, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we be able to remove tests from crypto_sign_test.ts in favor of native Node.js tests when we get more crypto APIs ported?

Implementation wise looks good to me, brings us closer to full polyfill - thanks for adding all the notImplemented errors.

I'll let @littledivy to review before approving.

@kt3k
Copy link
Member Author

kt3k commented Apr 17, 2023

Will we be able to remove tests from crypto_sign_test.ts in favor of native Node.js tests when we get more crypto APIs ported?

I think we can switch to parallel/test-crypto-sign-verify.js (which test most basic features of createSign and createVerify) in the future when we implement createPrivateKey, createPublicKey, generateKeyPairSync

littledivy
littledivy approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 5f44396 into denoland:main Apr 18, 2023
@kt3k kt3k deleted the node-create-verify branch April 18, 2023 12:04
levex pushed a commit that referenced this pull request Apr 18, 2023
@kt3k @levex
fix(ext/node): implement crypto.createVerify (#18703)
3afecb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju left review comments

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt3k @bartlomieju @littledivy