perf(ext/node): native vectored write for server streams #19752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
littledivy
commented
Jul 7, 2023
•
littledivy
commented
littledivy
changed the title
lucacasonato
reviewed
Jul 7, 2023
aapoalas
reviewed
Jul 7, 2023
bartlomieju
reviewed
Jul 7, 2023
There was a problem hiding this comment.
LGTM, but I want more eyes on this. Pinging @mmastrac for additional review.
mmastrac
reviewed
Jul 7, 2023
| if (typeof chunks[0] === "string") chunks[0] = Buffer.from(chunks[0]); | ||
| if (typeof chunks[1] === "string") chunks[1] = Buffer.from(chunks[1]); | ||
|
|
||
| ops.op_raw_write_vectored( |
There was a problem hiding this comment.
Is this path called with chunks.length == 1 anywhere? There may be an opportunity to optimize for N <= M instead of N == 2.
There was a problem hiding this comment.
chunks.length == 1 should be using write instead of writev
mmastrac
reviewed
Jul 7, 2023
| buf1: JsBuffer, | ||
| buf2: JsBuffer, | ||
| ) -> Result<usize, AnyError> { | ||
| let resource: Rc<UpgradeStream> = |
There was a problem hiding this comment.
If this is not an UpgradeStream, it should probably fall back to the standard write methods. I don't think we should assume that any two-chunk write is a websocket write.
There was a problem hiding this comment.
In JS, All TCPSERVERWRAP provider type resources are an UpgradeStream so this does not need a fallback.
mmastrac
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.