fix(node): TLSSocket._start

[bartlomieju]

Closes #19983
Closes #18303
Closes #16681
Closes #19978

[ije]

@bartlomieju can you please also fix it as 0.177.2 for esm.sh? thanks!

[bartlomieju]

@bartlomieju can you please also fix it as 0.177.2 for esm.sh? thanks!

I don't think so, it will require a lot of changes and most likely be using APIs not available in 0.177.2.

[ije]

makes sense

[bartlomieju]

Reproduction

import nodemailer  from "nodemailer";

nodemailer.createTestAccount((err, account) => {
    if (err) {
        console.error('Failed to create a testing account. ' + err.message);
        return process.exit(1);
    }

    console.log('Credentials obtained, sending message...');

    // Create a SMTP transporter object
    let transporter = nodemailer.createTransport({
        host: account.smtp.host,
        port: account.smtp.port,
        secure: account.smtp.secure,
        auth: {
            user: account.user,
            pass: account.pass
        }
    });

    console.log("transporter", transporter);

    // Message object
    let message = {
        from: 'Sender Name <sender@example.com>',
        to: 'Recipient <recipient@example.com>',
        subject: 'Nodemailer is unicode friendly ✔',
        text: 'Hello to myself!',
        html: '<p><b>Hello</b> to myself!</p>'
    };
    console.log("before send");
    transporter.sendMail(message, (err, info) => {
        console.log("after send");
        if (err) {
            console.log('Error occurred. ' + err.message);
            return process.exit(1);
        }

        console.log('Message sent: %s', info.messageId);
        // Preview only available when sending through an Ethereal account
        console.log('Preview URL: %s', nodemailer.getTestMessageUrl(info));
    });
});

[bartlomieju]

Closing in favor of #20120