Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): propagate create cipher errors #20280

Merged
merged 3 commits into from
Aug 26, 2023
Merged

fix(node): propagate create cipher errors #20280

merged 3 commits into from
Aug 26, 2023

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Aug 25, 2023 •
edited
Loading

Fixes #19002

bartlomieju
bartlomieju approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member

@littledivy is there an issue this PR closes?

@littledivy
Copy link
Member Author

Updated description.

@littledivy littledivy merged commit 1cb547d into denoland:main Aug 26, 2023
bartlomieju pushed a commit that referenced this pull request Aug 31, 2023
@littledivy @bartlomieju
fix(node): propagate create cipher errors (#20280)
999bc87 
Fixes #19002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad resource ID using web-push (Node.js)
2 participants
@littledivy @bartlomieju