Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jupyter): more robust Deno.jupyter namespace #20710

Merged
merged 7 commits into from
Sep 28, 2023
Merged

fix(jupyter): more robust Deno.jupyter namespace #20710

merged 7 commits into from
Sep 28, 2023

Conversation

bartlomieju
Copy link
Member

Blocked by #20704

rgbkrk
rgbkrk reviewed Sep 27, 2023
View reviewed changes
cli/tests/testdata/jupyter/integration_test.ipynb
]
"data": {
"text/html": [
"<b>Complete ✅</b>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

cli/tests/testdata/jupyter/integration_test.ipynb
"data": {},
"execution_count": 21,
"metadata": {},
"output_type": "execute_result"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a separate PR, we should make sure to not send an execute_result if we don't have any payload.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that looks like a bug, we should be skipping this message if the only value is undefined.

@bartlomieju bartlomieju marked this pull request as ready for review September 27, 2023 11:02
rgbkrk
rgbkrk approved these changes Sep 27, 2023
View reviewed changes
cli/tools/jupyter/server.rs
"metadata": {},
}))
.send(&mut *self.iopub_socket.lock().await)
.await?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@rgbkrk
Copy link
Contributor

rgbkrk commented Sep 27, 2023 •
edited
Loading

Confirmed that Deno.jupyter.broadcast is working well via this branch (fixes the main branch not having access to Deno.jupyter).

image

@manzt manzt mentioned this pull request Sep 27, 2023
Merged
mmastrac
mmastrac approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 0bd53fd into denoland:main Sep 28, 2023
12 checks passed
@bartlomieju bartlomieju deleted the fix_jupyter_test branch September 28, 2023 14:51
@rgbkrk rgbkrk mentioned this pull request Oct 1, 2023
Open
@rgbkrk rgbkrk mentioned this pull request Oct 8, 2023
Closed
bartlomieju added a commit that referenced this pull request Oct 12, 2023
@bartlomieju
fix(jupyter): more robust Deno.jupyter namespace (#20710)
a913a54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgbkrk rgbkrk rgbkrk approved these changes

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bartlomieju @rgbkrk @mmastrac @lucacasonato