Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): process.argv0 #20925

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(ext/node): process.argv0 #20925

merged 1 commit into from
Oct 17, 2023

Conversation

bartlomieju
Copy link
Member

Fixes #20924

kt3k
kt3k approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 5095af7 into denoland:main Oct 17, 2023
12 checks passed
@bartlomieju bartlomieju deleted the fix_process_argv0 branch October 17, 2023 23:51
@birkskyum birkskyum mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-compat: npm:oracledb(thin mode)
2 participants
@bartlomieju @kt3k