Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: unify CDP types in a single module #21094

Merged
merged 2 commits into from
Nov 5, 2023
Merged

refactor: unify CDP types in a single module #21094

merged 2 commits into from
Nov 5, 2023

Conversation

bartlomieju
Copy link
Member

This commit moves all Chrome Devtools Protocol messages to cli/cdp.rs
and refactors all places using these types to pull them from a common place.

No functional changes.

@bartlomieju bartlomieju requested a review from dsherret November 5, 2023 22:32
dsherret
dsherret approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju enabled auto-merge (squash) November 5, 2023 22:38
@bartlomieju bartlomieju merged commit fdb4953 into denoland:main Nov 5, 2023
@bartlomieju bartlomieju deleted the cdp_types branch November 5, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret