Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package_json.rs): Fix Package.Json overrides section ignored by Deno #21494

Closed
wants to merge 1 commit into from

Conversation

JonathonRP
Copy link

@JonathonRP JonathonRP commented Dec 7, 2023

this PR is to close #20614
@qheolet
@bartlomieju

Signed-off-by: Jonathon Reese Perry <jreesep@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Dec 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this implements this feature where dependencies of dependencies get overriden. Please see https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides

Perhaps for the time being we should instead print a warning that Deno ignores overrides and instead someone should use the new --unstable-byonm support if they want it which would have support for this feature (see https://deno.com/blog/v1.38#nodejs-compatibility-improvements)

@JonathonRP
Copy link
Author

I don't believe this implements this feature where dependencies of dependencies get overriden. Please see https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides

Perhaps for the time being we should instead print a warning that Deno ignores overrides and instead someone should use the new --unstable-byonm support if they want it which would have support for this feature (see https://deno.com/blog/v1.38#nodejs-compatibility-improvements)

you are possible correct, I don't know rust well but wanted to get this going. but I like your proposal of using the --unstable-byonm

@JonathonRP
Copy link
Author

I don't believe this implements this feature where dependencies of dependencies get overriden. Please see https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides
Perhaps for the time being we should instead print a warning that Deno ignores overrides and instead someone should use the new --unstable-byonm support if they want it which would have support for this feature (see https://deno.com/blog/v1.38#nodejs-compatibility-improvements)

you are possible correct, I don't know rust well but wanted to get this going. but I like your proposal of using the --unstable-byonm

I am attempting this now and getting this error -
image

@JonathonRP JonathonRP marked this pull request as draft December 8, 2023 16:40
@JonathonRP
Copy link
Author

I don't believe this implements this feature where dependencies of dependencies get overriden. Please see https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides
Perhaps for the time being we should instead print a warning that Deno ignores overrides and instead someone should use the new --unstable-byonm support if they want it which would have support for this feature (see https://deno.com/blog/v1.38#nodejs-compatibility-improvements)

you are possible correct, I don't know rust well but wanted to get this going. but I like your proposal of using the --unstable-byonm

I am attempting this now and getting this error - image

got around this by installing pnpm standalone script and using it's node version manager built-in

@JonathonRP JonathonRP closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno - does not support override property in the package.json
3 participants