Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): update req.socket on WS upgrade #21984

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Jan 18, 2024

Update the req.socket to be a net.Socket from FakeSocket

Fixes #21979

@littledivy littledivy changed the title fix(node): update socket held by request on WS upgrade fix(node): update req.socket on WS upgrade Jan 18, 2024
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is a test possible?

@littledivy littledivy merged commit 66ff28c into denoland:main Jan 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Next.js HMR websocket n.write is not a function
3 participants