feat: Add warnings for more deprecated APIs #21992
Conversation
Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
|
Note: |
ext/io/12_io.js
Outdated
| internals.warnOnDeprecatedApi( | ||
| "Deno.iter()", | ||
| new Error().stack, | ||
| "Use `ReadableStreamDefaultReader` instead.", |
There was a problem hiding this comment.
Err I don't understand this suggestion :( don't we have iter() equivalent in deno_std?
There was a problem hiding this comment.
No, that's deprecated. Should we add it back in? I was wondering whether we should add it back in...
There was a problem hiding this comment.
Probably not. Maybe we shouldn't add a suggestion here - this API relies on Reader interface that is also deprecated. So migrating the underlying Reader dictates which API should be used instead.
There was a problem hiding this comment.
The Reader interface in deno_std is no longer deprecated, so this might be fine to add back in.
Also, actually, should it not be ReadableStream instead? Both ReadableStream and Deno.iter() are async iterable.
We can either add iter() back to deno_std or suggest ReadableStream.
There was a problem hiding this comment.
Let's suggest ReadableStream 👍
There was a problem hiding this comment.
I realise doing this all in runtime/js/90_deno_ns.js will be cleaner.
Follow up to #21939 that adds deprecation
warnings to more
DenoAPIs:Deno.copy()Deno.iter()Deno.iterSync()new Deno.Buffer()Deno.readAll()Deno.readAllSync()Deno.writeAll()Deno.writeAllSync()Deno.FsWatcher.returnDeno.serveHttp()Deno.metrics()