Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/fs): promises not exporting fs constants #21997

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

marvinhagemeister
Copy link
Contributor

We were missing the constants export in the promise fs API which is available in node.

import { constants, promises } from "node:fs";
import { constants as fsPromiseConstants } from "node:fs/promises";
console.log(constants === promises.constants); // logs: true
console.log(constants === fsPromiseConstants); // logs: true

Fixes #21994

@marvinhagemeister marvinhagemeister merged commit 6927382 into main Jan 21, 2024
14 checks passed
@marvinhagemeister marvinhagemeister deleted the node-fs-promise-constants branch January 21, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'node:fs/promises' does not export 'constants'
2 participants