Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate Deno.FsFile constructor and Deno.FsFile.rid #22072

Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jan 24, 2024

For removal in Deno 2.0. Other deprecations must be merged first.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jan 24, 2024

Actually, this can be merged now. Further cleanups can come after.

@iuioiua iuioiua marked this pull request as ready for review January 24, 2024 08:29
@bartlomieju bartlomieju merged commit aac0ad3 into denoland:main Jan 24, 2024
17 checks passed
@iuioiua iuioiua deleted the deprecate-Deno.FsFile-constructor-and-rid branch January 24, 2024 18:00
bartlomieju added a commit that referenced this pull request Jan 25, 2024
Regression caused by #22072.

I added a relevant test so we don't regress again.

Fixes #22115
bartlomieju added a commit that referenced this pull request Jan 26, 2024
Regression caused by #22072.

I added a relevant test so we don't regress again.

Fixes #22115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants