Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): forward granular --unstable-* flags #22164

Merged
merged 3 commits into from
Feb 1, 2024
Merged

fix(install): forward granular --unstable-* flags #22164

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e474dd4
fix(install): forward granular --unstable-* flags
bartlomieju Jan 28, 2024
145e8da
Merge branch 'main' into fix_install_unstable_flags
bartlomieju Jan 28, 2024
db42512
Merge branch 'main' into fix_install_unstable_flags
bartlomieju Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions cli/tools/installer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,10 @@ async fn resolve_shim_data(
executable_args.push("--unstable".to_string());
}

for feature in &flags.unstable_config.features {
executable_args.push(format!("--unstable-{}", feature));
}

if flags.no_remote {
executable_args.push("--no-remote".to_string());
}
Expand Down Expand Up @@ -706,6 +710,73 @@ mod tests {
);
}

#[tokio::test]
async fn install_unstable_legacy() {
let shim_data = resolve_shim_data(
&Flags {
unstable_config: UnstableConfig {
legacy_flag_enabled: true,
..Default::default()
},
..Default::default()
},
&InstallFlags {
module_url: "http://localhost:4545/echo_server.ts".to_string(),
args: vec![],
name: None,
root: Some(env::temp_dir().to_string_lossy().to_string()),
force: false,
},
)
.await
.unwrap();

assert_eq!(shim_data.name, "echo_server");
assert_eq!(
shim_data.args,
vec![
"run",
"--unstable",
"--no-config",
"http://localhost:4545/echo_server.ts",
]
);
}

#[tokio::test]
async fn install_unstable_features() {
let shim_data = resolve_shim_data(
&Flags {
unstable_config: UnstableConfig {
features: vec!["kv".to_string(), "cron".to_string()],
..Default::default()
},
..Default::default()
},
&InstallFlags {
module_url: "http://localhost:4545/echo_server.ts".to_string(),
args: vec![],
name: None,
root: Some(env::temp_dir().to_string_lossy().to_string()),
force: false,
},
)
.await
.unwrap();

assert_eq!(shim_data.name, "echo_server");
assert_eq!(
shim_data.args,
vec![
"run",
"--unstable-kv",
"--unstable-cron",
"--no-config",
"http://localhost:4545/echo_server.ts",
]
);
}

#[tokio::test]
async fn install_inferred_name_from_parent() {
let shim_data = resolve_shim_data(
Expand Down
Loading