fix(runtime): return number from op_ppid instead of bigint
#22169
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
changed the title
op_ppid from i64 to u32op_ppid from i64 to i32
magurotuna
force-pushed
the
magurotuna/issue22166
branch
from
9c1ced8 to
d937aaf
Compare
mmastrac
reviewed
Jan 29, 2024
| @@ -32,8 +32,8 @@ fn op_main_module(state: &mut OpState) -> Result<String, AnyError> { | |||
| /// This is an op instead of being done at initialization time because | |||
| /// it's expensive to retrieve the ppid on Windows. | |||
| #[op2(fast)] | |||
| #[bigint] | |||
There was a problem hiding this comment.
You can keep this as i64 and use #[number] here to force it to return an integer-like number up to MAX_SAFE_INTEGER
magurotuna
changed the title
op_ppid from i64 to i32op_ppid instead of bigint
littledivy
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22166