feat(node): crypto.{Cipheriv,Decipheriv}.setAutoPadding()
#22228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
reviewed
Feb 2, 2024
iuioiua
changed the title
Cipheriv.setAutoPadding()(Cipheriv|Decipheriv).setAutoPadding()
iuioiua
changed the title
(Cipheriv|Decipheriv).setAutoPadding()crypto.{Cipheriv,Decipheriv}.setAutoPadding()
|
@littledivy, are you able to see where I went wrong? Also, I thought |
Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
littledivy
reviewed
Feb 9, 2024
Comment on lines
351
to
+353
| buf, | ||
| this.#authTag || NO_TAG, | ||
| this.#autoPadding, |
There was a problem hiding this comment.
The tests are failing because buf is a fixed buffer of size 16 (block size).
When auto padding is disabled, buf should be sliced from (0, len] where len is the length of the unpadded block returned by decrypt_block_b2b_mut
Signed-off-by: Asher Gomez <ashersaupingomez@gmail.com>
This reverts commit b52deba.
|
@iuioiua FYI I don't think I'll have time to get this in for 1.41. It's a little more work than I thought - will keep you updated |
|
Closing in favor #24940. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21804