Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): disable no-cache diagnostics for jsr specifiers #22284

Merged
merged 1 commit into from
Feb 6, 2024
Merged

fix(lsp): disable no-cache diagnostics for jsr specifiers #22284

merged 1 commit into from
Feb 6, 2024
+25 −0

Conversation

nayeemrmn
Copy link
Collaborator

No description provided.

dsherret
dsherret approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a quick fix.

@nayeemrmn nayeemrmn merged commit 327b5b2 into denoland:main Feb 6, 2024
15 checks passed
@nayeemrmn nayeemrmn deleted the lsp-jsr-uncached-no-error branch February 7, 2024 04:48
littledivy pushed a commit that referenced this pull request Feb 8, 2024
@nayeemrmn @littledivy
fix(lsp): disable no-cache diagnostics for jsr specifiers (#22284)
3d0b1ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nayeemrmn @dsherret