-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(unstable/lint): no-slow-types for JSR packages #22430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Can you add the scary warning when a user specifies the allow flag?
Can you also open an issue for showing these in the LSP?
); | ||
if !any_pkg_had_diagnostics { | ||
// this is a temporary measure until we know that fast check is reliable and stable | ||
let check_diagnostics = type_checker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also run a type check before publish (without fast check) - let's do that in a follow up. And the if the user passes --no-check we should maybe also ignore the fast check verification type check
Good feedback. Thanks! I opened #22437 |
no-slow-types
lint rule.deno lint
for packages (deno.json files with a name, version, and exports field)--no-slow-types