Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): type check local files for no-slow-types #22501

Closed
wants to merge 2 commits into from

Conversation

dsherret
Copy link
Member

We were type checking remotes and everything.

Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret
Copy link
Member Author

Based on the failing tests I now see this will affect type checking. I'm going to instead open a PR that adds type checking to deno publish, which is something that was discussed recently.

@dsherret dsherret closed this Feb 20, 2024
@dsherret dsherret deleted the fix_publish_type_check_local branch February 20, 2024 22:44
@dsherret dsherret restored the fix_publish_type_check_local branch February 20, 2024 22:46
@dsherret dsherret deleted the fix_publish_type_check_local branch February 20, 2024 22:46
dsherret added a commit that referenced this pull request Feb 21, 2024
Supersedes #22501 and also fixes that issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants