fix(ext/node): initial crypto.createPublicKey() support
#22509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Feb 21, 2024
ext/node/ops/crypto/mod.rs
Outdated
| #[string] type_: &str, | ||
| ) -> Result<AsymmetricKeyDetails, AnyError> { | ||
| let doc = parse_public_key(key, format, type_)?; | ||
| let pk_info = pkcs8::SubjectPublicKeyInfo::try_from(doc.as_bytes())?; |
There was a problem hiding this comment.
Rust is telling me the value I'm passing to try_from() is incorrect.
| }) | ||
| } | ||
| RSASSA_PSS_OID => { | ||
| let params = PssPrivateKeyParameters::try_from( |
There was a problem hiding this comment.
IIUC, the PssPrivateKeyParameters should be renamed to PssKeyParameters, as it also applies to public keys.
littledivy
changed the title
crypto.createPublicKey()crypto.createPublicKey() support
|
Great stuff! LGTM. However, this should be marked as "feat". |
|
@iuioiua All the Node API changes are merged as fixes so we can include them in patch releases. |
littledivy
approved these changes
Mar 13, 2024
magurotuna
pushed a commit
to magurotuna/deno
that referenced
this pull request
Mar 13, 2024
…2509) Closes denoland#21807 Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
nathanwhit
pushed a commit
that referenced
this pull request
Mar 14, 2024
Closes #21807 Co-authored-by: Divy Srivastava <dj.srivastava23@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21807
CC @littledivy