Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(cli): reduce overhead in test registration #22552

Merged
merged 5 commits into from
Feb 28, 2024
Merged

perf(cli): reduce overhead in test registration #22552

merged 5 commits into from
Feb 28, 2024

Conversation

mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Feb 23, 2024 •
edited
Loading

  • Removes the origin call, since all origins are the same for an isolate (ie: the main module)
  • Collects the TestDescriptions and sends them all at the same time inside of an Arc, allowing us to (later on) re-use these instead of cloning.

Needs a follow-up pass to remove all the cloning, but that's a thread that is pretty long to pull

@mmastrac mmastrac requested a review from dsherret February 27, 2024 01:27
dsherret
dsherret approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmastrac mmastrac merged commit 96cfe82 into denoland:main Feb 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmastrac @dsherret