Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): import map expansion #22553

Merged
merged 5 commits into from
Feb 24, 2024
Merged

fix(lsp): import map expansion #22553

merged 5 commits into from
Feb 24, 2024
+201 −371

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 23, 2024 •
edited
Loading

image

Closes #22270

@dsherret dsherret mentioned this pull request Feb 23, 2024
Merged
@dsherret dsherret marked this pull request as ready for review February 23, 2024 23:15
dsherret
dsherret commented Feb 24, 2024
View reviewed changes
tests/testdata/run/workspaces/basic/main.out
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't add a language server specific test for this because the code is no longer language server specific, so I didn't think it was worth it because it's tested elsewhere in the lower level code.

nayeemrmn
nayeemrmn approved these changes Feb 24, 2024
View reviewed changes
Copy link
Collaborator

@nayeemrmn nayeemrmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 6567dc9 into denoland:main Feb 24, 2024
17 checks passed
@dsherret dsherret deleted the fix_lsp_import_map_expansion branch February 24, 2024 05:21
@dsherret dsherret mentioned this pull request Mar 2, 2024
Merged
dsherret added a commit that referenced this pull request Mar 2, 2024
@dsherret
fix(lsp): regression - caching in lsp broken when config with imports…
0973e8e 
… has comments (#22666)

Caused by #22553

Closes #22664
littledivy pushed a commit that referenced this pull request Mar 8, 2024
@dsherret @littledivy
fix(lsp): regression - caching in lsp broken when config with imports…
f1e50cd 
… has comments (#22666)

Caused by #22553

Closes #22664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayeemrmn nayeemrmn nayeemrmn approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import map expansion doesn't work in LSP
2 participants
@dsherret @nayeemrmn