Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): set correct process.argv0 #22555

Merged
merged 3 commits into from
Feb 23, 2024
Merged

fix(ext/node): set correct process.argv0 #22555

merged 3 commits into from
Feb 23, 2024

Conversation

satyarohith
Copy link
Member

Closes #20934

@satyarohith satyarohith enabled auto-merge (squash) February 23, 2024 08:38
@satyarohith satyarohith requested a review from dsherret February 23, 2024 16:23
Comment on lines +273 to +277
args: [
"eval",
`import process from "node:process";console.log(process.argv0);`,
],
stdout: "piped",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another test that does: import { argv0 } from "node:process" and checks the value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartlomieju opened another PR #22568 as I had auto-merge enabled for this one.

@satyarohith satyarohith merged commit 47dee65 into main Feb 23, 2024
17 checks passed
@satyarohith satyarohith deleted the fix_argv0 branch February 23, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node-compat: process.argv0
2 participants