Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): jsr specifier completions #22612

Merged
merged 6 commits into from
Feb 29, 2024
Merged

feat(lsp): jsr specifier completions #22612

merged 6 commits into from
Feb 29, 2024

Conversation

nayeemrmn
Copy link
Collaborator

No description provided.

dsherret
dsherret approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

cli/lsp/completions.rs Show resolved Hide resolved
@dsherret dsherret mentioned this pull request Feb 28, 2024
Merged
@nayeemrmn nayeemrmn merged commit 3a43568 into denoland:main Feb 29, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-jsr-specifier-completions branch February 29, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nayeemrmn @marvinhagemeister @dsherret