Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publish): reland error if there are uncommitted changes (#22613) #22632

Merged
merged 13 commits into from
Mar 7, 2024
Merged

fix(publish): reland error if there are uncommitted changes (#22613) #22632

merged 13 commits into from
Mar 7, 2024
+148 −3

Conversation

bartlomieju
Copy link
Member

Reverted in #22625

@bartlomieju bartlomieju added the ci-full put this on a PR to run the full CI label Feb 29, 2024
@bartlomieju bartlomieju changed the title reland: error if there are uncommitted changes (#22613) Reland: fix(publish): error if there are uncommitted changes (#22613) Feb 29, 2024
@bartlomieju bartlomieju changed the title Reland: fix(publish): error if there are uncommitted changes (#22613) Reland fix(publish): error if there are uncommitted changes (#22613) Feb 29, 2024
@bartlomieju bartlomieju changed the title Reland fix(publish): error if there are uncommitted changes (#22613) Reland: fix(publish): error if there are uncommitted changes (#22613) Feb 29, 2024
@bartlomieju bartlomieju changed the title Reland: fix(publish): error if there are uncommitted changes (#22613) fix(publish): reland error if there are uncommitted changes (#22613) Feb 29, 2024
@bartlomieju bartlomieju added ci-bench put this on a PR to run the benchmarks and removed ci-full put this on a PR to run the full CI labels Mar 6, 2024
@bartlomieju bartlomieju added the ci-full put this on a PR to run the full CI label Mar 6, 2024
@bartlomieju bartlomieju requested a review from dsherret March 6, 2024 23:48
@bartlomieju bartlomieju removed the ci-full put this on a PR to run the full CI label Mar 7, 2024
dsherret
dsherret approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju merged commit 914b749 into denoland:main Mar 7, 2024
17 checks passed
@bartlomieju bartlomieju deleted the reland_uncomitted_changes branch March 7, 2024 21:14
littledivy pushed a commit that referenced this pull request Mar 8, 2024
@bartlomieju @littledivy
fix(publish): reland error if there are uncommitted changes (#22613) (#…
338fe7e 
…22632)

Reverted in #22625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
ci-bench put this on a PR to run the benchmarks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret