fix: don't include source maps in release mode #22751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Mar 6, 2024
runtime/shared.rs
Outdated
| .map(|sm| sm.into_bytes().into()) | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
Maybe we should just fix this in deno_ast instead of landing this somewhat of a hack? It's a few lines of code change to fix it there and then we can do a quick patch release.
There was a problem hiding this comment.
I can fix it in deno_ast right now. Just give me a few minutes.
This reverts commit 7718e90.
littledivy
pushed a commit
that referenced
this pull request
Mar 8, 2024
Due to bug in `deno_ast` the `source_map` setting is ignored and source map is always emitted. This is fixed by updating `deno_ast`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to bug in
deno_astthesource_mapsetting is ignored and source mapis always emitted. This is fixed by updating
deno_ast.