Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): add nul byte to statfs path on windows #22905

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Tentatively closes #22897.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

ext/node/ops/fs.rs Show resolved Hide resolved
ext/node/ops/fs.rs Outdated Show resolved Hide resolved
@nayeemrmn nayeemrmn changed the title fix(node): retry GetDiskFreeSpaceW on failure fix(node): add null byte to statfs path on windows Mar 13, 2024
@nayeemrmn nayeemrmn changed the title fix(node): add null byte to statfs path on windows fix(node): add nul byte to statfs path on windows Mar 13, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again!

@nayeemrmn nayeemrmn merged commit da58722 into denoland:main Mar 13, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the retry-statfs-windows branch March 14, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_unit_tests::_fs_statfs_test is flaky on windows
2 participants