Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface dynamic import in core #2472

Merged
merged 5 commits into from
Jun 10, 2019
Merged

Surface dynamic import in core #2472

merged 5 commits into from
Jun 10, 2019

Conversation

ry
Copy link
Member

@ry ry commented Jun 7, 2019 •
edited
Loading

Towards #1789

@ry ry changed the title WIP surface dynamic import in core Surface dynamic import in core Jun 10, 2019
@ry ry force-pushed the dyn_import branch 2 times, most recently from 6adec23 to 037a309 Compare June 10, 2019 16:04
piscisaureus
piscisaureus approved these changes Jun 10, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ry ry merged commit e043697 into denoland:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ry @piscisaureus