fix(ext/http): do not set localhost to hostname unnecessarily #24777
+36
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
approved these changes
Jul 29, 2024
iuioiua
approved these changes
Aug 19, 2024
|
@bartlomieju Does this change look reasonable? |
jsejcksn
reviewed
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes when to cause the hostname substition of
0.0.0.0->localhost.Currently we substitute
localhostto the hostname on windows before callingoptions.onListen, which prevents the users to do more advanced thing using hostname string like denoland/std#5558. This PR changes it not to substitute it when the user provideonListencallback.closes #24776
unblocks denoland/std#5558