Combine CLI Errors.

[kitsonk]

Resolves #2474

Outside of core::JSError, all other Deno errors are now combined to be just DenoError.

I need to do further work on this PR, but wanted to get it visible to get any early feedback. Things I still need to do:

• cli/errors.rs has no tests at all, add tests
• Align the display of JSError (JSErrorColor) to be more like TypeScript diagnostics
• Align the display of the other Deno errors to be more like TypeScript diagnostics
• Bubble up non-diagnostic errors in the compiler worker

[kitsonk]

Ok, I have taken some artistic license with the errors to try to unify them, as neither TypeScript nor a coloured version of JSError work very well universally.

The biggest change is I took a hint from Rust errors which look something like this:

error[E0053]: method `format_related_info` has an incompatible type for trait
   --> ../../cli/fmt_errors.rs:122:26

Where TypeScript pretty errors led with the file location of the error, that really breaks up being to read them because on average, we output very long file identifiers that identify local and remote resources.

A TypeScript error looks like this (but in colour):

error TS2322: Type '(o: T) => { v: any; f: (x: B) => string; }[]' is not assignable to type '(r: B) => Value<B>[]'.
  Types of parameters 'o' and 'r' are incompatible.
    Type 'B' is not assignable to type 'T'.
      'B' is assignable to the constraint of type 'T', but 'T' could be instantiated with a different subtype of constraint '{}'.

► file:///Users/kkelly/github/deno/tests/error_003_typescript.ts:20:3

20   values: o => [
     ~~~~~~

  The expected type comes from property 'values' which is declared here on type 'C<B>'

    ► file:///Users/kkelly/github/deno/tests/error_003_typescript.ts:8:3

    8   values?: (r: T) => Array<Value<T>>;
        ~~~~~~


error TS2339: Property 't' does not exist on type 'T'.

► file:///Users/kkelly/github/deno/tests/error_003_typescript.ts:22:12

22       v: o.t,
              ^


Found 2 errors.

And a JavaScript error looks like this:

error: Uncaught Error: exception from mod1
► file:///Users/kkelly/github/deno/tests/subdir/mod1.ts:16:9

16   throw Error("exception from mod1");
           ^

    at throwsError (file:///Users/kkelly/github/deno/tests/subdir/mod1.ts:16:9)
    at foo (file:///Users/kkelly/github/deno/tests/error_002.ts:4:3)
    at file:///Users/kkelly/github/deno/tests/error_002.ts:7:1

Also, I have remapped the top line, start_column, end_column and line contents from JSErrors, so you get authored code instead of transpiled code.

[ry]

Why is the squiggly red in one place but teal in another

I like the arrows

[kitsonk]

That follow the TypeScript model, squiggly red for an error, and squiggly teal/cyan for non-errors, where it is indicating a reference of where something is defined.

I should be able to finish off the tests today and get it into a green state.

[kitsonk]

For reference, Rust also uses cyan when underlining "help":

[kitsonk]

Ok, I think this is ready for a final review @ry.

I didn't tackle the other error kinds display, as these are intrinsically Rust errors and are generally handled differently (usually via a panic!()) which gives more Rust context by default.

Also, I didn't handle bubbling up the worker JavaScript errors. I suspect it would be more straightforward to do that in a seperate PR now that there is a unified error infrastructure.

[ry]

Just a couple nits - looks great!

[kitsonk]

@ry feedback addressed (and I forgot to test the source line remapping in source map, though it was being covered by the integrations tests).

[ry]

LGTM