Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor module resolving #2493

Merged
merged 15 commits into from
Jun 12, 2019
Merged

Refactor module resolving #2493

merged 15 commits into from
Jun 12, 2019

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Jun 10, 2019 •
edited
Loading

Closes #2482

ry
ry reviewed Jun 11, 2019
View reviewed changes
cli/worker.rs Outdated Show resolved Hide resolved
@bartlomieju bartlomieju force-pushed the refactor_resolve_module_spec branch from e5e540b to c0e3912 Compare June 12, 2019 09:50
@bartlomieju bartlomieju changed the title WIP: add ModuleSpecifier struct add ModuleSpecifier struct Jun 12, 2019
@bartlomieju bartlomieju marked this pull request as ready for review June 12, 2019 10:28
@bartlomieju bartlomieju changed the title add ModuleSpecifier struct Refactor module resolving Jun 12, 2019
@bartlomieju
Copy link
Member Author

@ry this PR should be ready for review - if this is the right direction then I'll apply ModuleSpecifier to import maps and add test cases for resolution algorithm.

I'm not super-happy I had to rewrite test cases in core/modules.rs...

ry
ry reviewed Jun 12, 2019
View reviewed changes
cli/state.rs Show resolved Hide resolved
cli/state.rs Outdated Show resolved Hide resolved
cli/worker.rs Show resolved Hide resolved
core/BUILD.gn Outdated Show resolved Hide resolved
core/modules.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member Author

@ry can you also take a look at op_fetch_module_meta_data and TODO comment there? Maybe we can resolve that in single PR - it will allow to change signature of DenoDir::fetch_module_meta_data_async and open up a way for #2057

@bartlomieju bartlomieju force-pushed the refactor_resolve_module_spec branch from 4ff1c8a to e8ca049 Compare June 12, 2019 17:47
@bartlomieju
Copy link
Member Author

Removed ModuleSpecifier from //core, now it lives only in //cli.

ry
ry approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice clean up!

@ry ry merged commit b3c4307 into denoland:master Jun 12, 2019
@bartlomieju
Copy link
Member Author

@ry I'm gonna open another PR with changes to //core/ so the code doesn't get stale on my disk. Once you're comfortable with those changes we can merge them.

@bartlomieju bartlomieju deleted the refactor_resolve_module_spec branch June 12, 2019 19:03
@ry
Copy link
Member

ry commented Jun 12, 2019

Sounds good

@bartlomieju bartlomieju mentioned this pull request Jun 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use ModuleSpecifier for module resolving
2 participants
@bartlomieju @ry