Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): support deno upgrade 1.46.0 #25096

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

bartlomieju
Copy link
Member

This commit changes deno upgrade subcommand to accept
a positional argument that can be either a version, release channel
name or a git hash, making invocations of deno upgrade much
more concise:

# before
$ deno upgrade --version 1.46.0
# after 
$ deno upgrade 1.46.0
# before
$ deno upgrade --canary
# after
$ deno upgrade canary
# specific canary version before
$ deno upgrade --canary --version f042c39180c1b345de8e7b5f0dfae5d0a49b161f
# after
$ deno upgrade f042c39180c1b345de8e7b5f0dfae5d0a49b161f

Old flags are still supported, but hidden from the help output.

@bartlomieju bartlomieju added this to the 1.46 milestone Aug 19, 2024
cli/tools/upgrade.rs Outdated Show resolved Hide resolved
@bartlomieju
Copy link
Member Author

bartlomieju commented Aug 19, 2024

IMPORTANT: Update doc page before landing

Actually I'm gonna give it a couple weeks to let users upgrade to the version that supports this syntax before updating docs.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit c94c5cd into denoland:main Aug 19, 2024
17 checks passed
@bartlomieju bartlomieju deleted the upgrade_single_arg branch August 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants