Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lsp): changes for lsp_types 0.97.0 #25169

Merged
merged 11 commits into from
Aug 24, 2024

Conversation

nayeemrmn
Copy link
Collaborator

@nayeemrmn nayeemrmn commented Aug 23, 2024

Blocked by ebkalderon/tower-lsp#401. But currently this PR patches that revision in Cargo.toml so this could be landed.

Unblocks jupyter cell continuity: denoland/vscode_deno#932.

@nayeemrmn nayeemrmn marked this pull request as ready for review August 23, 2024 01:19
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, I'll wait for David's approval

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we can't publish to crates.io after landing this pr (which may or may not be a problem)

@nayeemrmn nayeemrmn merged commit 2ab4afc into denoland:main Aug 24, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-jupyter-cell-continuity branch August 27, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants