-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lsp): changes for lsp_types 0.97.0 #25169
Merged
nayeemrmn
merged 11 commits into
denoland:main
from
nayeemrmn:lsp-jupyter-cell-continuity
Aug 24, 2024
Merged
refactor(lsp): changes for lsp_types 0.97.0 #25169
nayeemrmn
merged 11 commits into
denoland:main
from
nayeemrmn:lsp-jupyter-cell-continuity
Aug 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Aug 23, 2024
bartlomieju
reviewed
Aug 23, 2024
bartlomieju
reviewed
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, I'll wait for David's approval
dsherret
reviewed
Aug 23, 2024
dsherret
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we can't publish to crates.io after landing this pr (which may or may not be a problem)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blockedby ebkalderon/tower-lsp#401. But currently this PR patches that revision inCargo.toml
so this could be landed.Unblocks jupyter cell continuity: denoland/vscode_deno#932.