feat(ext/node): add abort helpers, process & streams fix #25262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacasonato
force-pushed
the
fixes
branch
2 times, most recently
from
ddcbf1b
to
1fa8286
Compare
This commit adds: - `addAbortListener` in `node:events` - `aborted` in `node:util` - `execPath` and `execvArgs` named export from `node:process` - `getDefaultHighWaterMark` from `node:stream` The `execPath` is very hacky - because module namespaces can not have real getters, `execPath` is an object with a `toString()` method that on call returns the actual `execPath`, and replaces the `execPath` binding with the string. This is done so that we don't require the `execPath` permission on startup.
bartlomieju
reviewed
Sep 4, 2024
| export let execPath: string = Object.freeze({ | ||
| __proto__: String.prototype, | ||
| toString() { | ||
| execPath = Deno.execPath(); |
There was a problem hiding this comment.
This could happen during the bootstrap process when we're not warming up? Then we won't have to call it each time execPath is accessed?
bartlomieju
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds:
addAbortListenerinnode:events(fixes error: Uncaught SyntaxError: The requested module 'node:events' does not provide an export named 'addAbortListener' #25402)abortedinnode:util(towards ext/node: missing node:util APIs #21378)execPathandexecvArgsnamed export fromnode:processgetDefaultHighWaterMarkfromnode:streamThe
execPathis very hacky - because module namespaces can not have real getters,execPathis an object with atoString()method that on call returns the actualexecPath, and replaces theexecPathbinding with the string. This is done so that we don't require theexecPathpermission on startup.