fix(permissions): disallow any LD_ or DYLD_ prefixed env var without full --allow-run permissions
#25271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low-run permissions
marvinhagemeister
approved these changes
Aug 28, 2024
…ng when spawning the command
dsherret
changed the title
LD_ prefixed env var without full --allow-run permissionsLD_ or DYLD_ prefixed env var without full --allow-run permissions
bartlomieju
approved these changes
Aug 28, 2024
dsherret
deleted the
fix_disallow_any_ld_prefixed_env_var_without_allow_all
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #25221
I looked into what the list was and it was quite extensive, so I think as suggested in #11964 (comment) we should disallow this for any
LD_prefixed env var.