Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: print Listening on messages on stderr instead of stdout #25491

Merged
merged 11 commits into from
Sep 14, 2024

Conversation

marvinhagemeister
Copy link
Contributor

Fixes #25114

@marvinhagemeister
Copy link
Contributor Author

Looks like I need to wrestle with the CI a bit.

@bartlomieju
Copy link
Member

Appears we have a bug somewhere. console.error doesn't seem to respect NO_COLOR env var.

@bartlomieju bartlomieju added this to the 2.0.0-rc.3 milestone Sep 10, 2024
Co-authored-by: Nathan Whitaker <17734409+nathanwhit@users.noreply.github.com>
Signed-off-by: Leo Kettmeir <crowlkats@toaxl.com>
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 597f2d8 into main Sep 14, 2024
17 checks passed
@bartlomieju bartlomieju deleted the listening-stderr branch September 14, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno serve/Deno.serve - "Listening on ..." message should log to stderr instead of stdout
4 participants