Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): better error message on failure #25503

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Sep 7, 2024

When passing a wrong version here's the new message:

Screenshot 2024-09-07 at 14 18 12

Ideas for better coloring are welcome

@bartlomieju
Copy link
Member Author

Other coloring suggestions:

  1. green
    Screenshot 2024-09-07 at 14 15 39

  2. yellow
    Screenshot 2024-09-07 at 14 16 15

  3. bold
    Screenshot 2024-09-07 at 14 16 42

  4. mix
    Screenshot 2024-09-07 at 14 17 10

@bartlomieju
Copy link
Member Author

Or I guess I could just reuse the help output:
Screenshot 2024-09-07 at 14 19 19

@satyarohith
Copy link
Member

Or I guess I could just reuse the help output:

Screenshot 2024-09-07 at 14 19 19

sounds better to be consistent 👍

@bartlomieju bartlomieju merged commit c64aa50 into denoland:main Sep 11, 2024
17 checks passed
@bartlomieju bartlomieju deleted the imporve_update_error_message branch September 11, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants