Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(temporal/unstable): Remove obsoleted Temporal APIs part 2 #25505

Merged

Conversation

petamoriken
Copy link
Contributor

Mainly I removed Temporal.Calendar and Temporal.TimeZone and replaced them to APIs that handle calendar and timezone as strings.
tc39/proposal-temporal#2925

Related #24836

@petamoriken petamoriken marked this pull request as draft September 8, 2024 07:53
@petamoriken petamoriken marked this pull request as ready for review September 8, 2024 08:39
@bartlomieju bartlomieju added this to the 2.0.0-rc.2 milestone Sep 8, 2024
@bartlomieju
Copy link
Member

Sorry for the churn @petamoriken but we're rewriting quite a few tests from itest! to spec tests these days. Would you mind rebasing? I will review it once it goes green.

@petamoriken
Copy link
Contributor Author

@bartlomieju done!

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartlomieju bartlomieju enabled auto-merge (squash) September 10, 2024 19:35
@bartlomieju bartlomieju merged commit e522f4b into denoland:main Sep 10, 2024
17 checks passed
@petamoriken petamoriken deleted the remove/obsolated-temporal-api-part2 branch September 11, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants