Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): Stream should be instance of EventEmitter #25527

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix(ext/node): Stream should be instance of EventEmitter #25527

merged 1 commit into from
Sep 9, 2024

Conversation

satyarohith
Copy link
Member

@satyarohith satyarohith commented Sep 9, 2024 •
edited
Loading

Closes #25526

@satyarohith satyarohith enabled auto-merge (squash) September 9, 2024 12:25
@satyarohith satyarohith changed the title fix(ext/node): stream should be instance of EventEmitter fix(ext/node): Stream should be instance of EventEmitter Sep 9, 2024
@satyarohith satyarohith merged commit 5126ccb into denoland:main Sep 9, 2024
17 checks passed
@satyarohith satyarohith deleted the fix_stream_instance_of_event_emitter branch September 9, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ext/node: net.Socket is not an instance of EventEmitter
2 participants
@satyarohith @marvinhagemeister