fix(ext/node): avoid showing UNKNOWN error from TCP handle
#25550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR destroys Node.js stream with Deno's original error instead of
UNKNOWNerror from handle object.In
ext/node/polyfills/internal_binding/stream_wrap.ts, we try to simulate the system call error when reading from the internalDeno.Conn, however when it's used withtls.connectand the thrown error is a cert error (likeInvalidData: invalid peer certificate: UnknownIssuer), then that error can't be mapped using this list of errors and it becomesUNKNOWNerror.This PR stops that mapping to UNKNOWN error (because it just obscures the actual reason and leads to the confusion like #20293), and instead destroys the stream with the Deno's original error (This is not ideal for the compatibility, but at least it's better than obscuring the error reason with 'UNKNOWN' error in my view).
related #20293